Programming Assignment 1

File I/O, Console I/O, and Command-Line Arguments

Code Review for XXX XXX

Build Results

1. Javadoc: Missing comment for public declaration
   csci2912week1.java; line 23

2. Javadoc: Missing comment for public declaration
   csci2912week1.java; line 25

Requirements Verification

/**
 * A short description of the program.
 *
 * @author     Last Name, First Name
 * @assignment CSCI 2912 Assignment X
 * @date       Date
 */

This is the first line.
This is the second line.
This is the third line.
This is the fourth line.

[sample-input.txt]
1: This is the first line.
2: This is the second line.
3: This is the third line.
4: This is the fourth line.

Enter a file name or type 'exit' to quit.
-->

General Observations

Note these observations will not affect the grade.

1. Writing a method to display the contents of a file would simplify the implementation.

2. The application does not correctly parse input files with names that contain spaces.

3. To print the current date and time, it would have been simpler to use the Date class, which was discussed briefly in class and the relevant API was linked twice from the homework assignment.

4. The implementation is more complex that it needs to be. Please see the example implementation.

5. Avoid calling System.exit if possible. Calling this method abruptly terminates the JVM and is unsafe to execute in certain contexts. Consider this:

   public class Program {
       public static void main(String[] args) {
           try {
               System.out.println("Calling System.exit()...");
               System.exit(0);
   
               // This will not execute.
               System.out.println("System.exit() returned.");
   
           } finally {
   
               // Warning: This will not execute, either!
               System.out.println("Final block executing...");
           }
       }
   }

Sample Execution

$ java csci2912week1 input-1.txt input-2.txt

Enter filenames, seperated by a space: input-1.txt input-2.txt

[input-1.txt]
1: This is line one.
2: This is line two.
3: This is line three.
4: This is line four.
5: This is line five.
[input-2.txt]
6: This is line one.
7: This is line two.
8: This is line three.
9: This is line four.
10: This is line five.
11: This is line six.
12: This is line seven.

Enter a file name or type 'exit' to quit.
-->output-1.txt

[output-1.txt]
1: output-1.txt
2: Sat Feb 11 22:22:13 HST 2012

Enter a file name or type 'exit' to quit.
-->output-2.txt

[output-2.txt]
1: output-2.txt
2: Sat Feb 11 22:22:13 HST 2012

Enter a file name or type 'exit' to quit.
-->exit

$ java csci2912week1

Enter filenames, seperated by a space: "input 3.txt"

["input]
"input (The system cannot find the file specified)


Enter a file name or type 'exit' to quit.
-->exit

$ java csci2912week1 < /dev/null

Enter filenames, seperated by a space: Exception in thread "main" java.util.NoSuchElementException: No line found
        at java.util.Scanner.nextLine(Unknown Source)
        at csci2912week1.main(csci2912week1.java:39)

$ java csci2912week1

Enter filenames, seperated by a space: missing.txt

[missing.txt]
missing.txt (The system cannot find the file specified)


Enter a file name or type 'exit' to quit.
-->.

[.]
1: .
2: Sat Feb 11 22:30:43 HST 2012IO Exception


Enter a file name or type 'exit' to quit.
-->

[]
1: 
2: Sat Feb 11 22:30:43 HST 2012IO Exception


Enter a file name or type 'exit' to quit.
-->exit